search

redpanda-data / benthos

MIT License
210 stars 62 forks source link

root span is not created #99

Open apaladiychuk opened 3 weeks ago

apaladiychuk commented 3 weeks ago

root span issue in benthos stream without defined input.
root span is not created when I run benthos stream using production function from my source code . Please take a look on test envieronment that I create for reproduce this issue

https://github.com/apaladiychuk/benthos-issue

mihaitodor commented 2 weeks ago

Hey @apaladiychuk 👋 Sorry for the late reply. I just took a look at your code and I'm not sure why you're using a instead of a custom input. If you can replace that with a custom input, then you can call WrapBatchInputExtractTracingSpanMapping() which should do the trick. This API is used by the kafka input: https://github.com/redpanda-data/connect/blob/df39acca2d1788f6d1d444e7a3f7b6a4acf1ac94/internal/impl/kafka/input_sarama_kafka.go#L176.

There's also WrapInputExtractTracingSpanMapping() in case you don't need a batched input.

And there's also the matching WrapBatchOutputExtractTracingSpanMapping() and WrapOutputExtractTracingSpanMapping() for outputs if you wish to extract the tracing spans from the consumed message and merge them into the written result.