redpanda-data / connect

Fancy stream processing made operationally mundane
https://docs.redpanda.com/redpanda-connect/about/
8.14k stars 840 forks source link

Update mssql ADO connection strings to the Documentation. #2273

Open Someone894 opened 12 months ago

Someone894 commented 12 months ago

Hello,

currently I am trying to read data from an mssql database via Benthos. The database is secured with a password that contains special characters like "!" and "#"

I was unable to establish a connection to the database using the dsn provided in the documentation since the password was interpreted as the port. I got it working by having a look at the sources of Benthos and seeing that it uses go-mssqldb. Which in its documentation provided an ADO connection string that worked for me.

Since this is usefull to know, but not documented in the Benthos documentation I am starting this issue in hope the documentation gets updated with a link to the ADO connection strings of the go-mssqldb project.

mihaitodor commented 11 months ago

Hey @Someone894 👋 Note that another option is to URL-encode the password and then insert it in the DSN. Same for the username. I wasn't aware of the ADO format, but it looks like that's another option, as you discovered. It's a bit tricky to capture all these variations for all the database drivers in the Benthos docs, but it would be a good idea to at least link to the relevant documentation from each of the drivers. PRs are welcome.