search

redpanda-data / connect

Fancy stream processing made operationally mundane
https://docs.redpanda.com/redpanda-connect/about/
8.09k stars 813 forks source link

[elasticsearch] Suppress credentials in logs #2489

Closed tbnguyen1407 closed 5 months ago

tbnguyen1407 commented 5 months ago

Version

v4.26.0

Problem

Currently username and password are printed in the logs for elasticsearch.

level=info msg="Sending messages to Elasticsearch index at urls: [https://elastic:espass@elasticsearch-master.ns-ext:9200]" @service=benthos label=o_kafka_es_c path=root.output_resources

Feature request

Credentials should be masked in the logs.

Thank you.

mihaitodor commented 5 months ago

Hey @tbnguyen1407 👋 Thanks for reporting this issue! I opened #2494 to start a discussion about this and see what's the best way to address it.

Jeffail commented 5 months ago

Fixed with: https://github.com/benthosdev/benthos/commit/d5613d4ea772788472fb5930a73092656b267ffc