search

redpanda-data / connect

Fancy stream processing made operationally mundane
https://docs.redpanda.com/redpanda-connect/about/
8.09k stars 818 forks source link

Bug: nats_jetstream input has a logic error in the stream check #2576

Closed maxarndt closed 2 months ago

maxarndt commented 4 months ago

In nats_jetstream input processor, I cannot use the stream option without subject set.

Acording to the docs this should work:

https://github.com/benthosdev/benthos/blob/88c01d179d3aa4030795ac0f52459dd7a333284b/website/docs/components/inputs/nats_jetstream.md?plain=1#L190-L192

Reproduction

input:
  nats_jetstream:
    urls: [nats://srv:port]
    stream: "somestream"

Error:

ERRO Service closing due to: failed to init input path root.input: subject is empty @service=benthos

Solution

I'm going to open a PR. Hope this helps.

Edit: here it is #2577

josephwoodward commented 2 months ago

@mihaitodor, I believe this issue can be closed now?

mihaitodor commented 2 months ago

Yep, the fix made it in v4.29.0.