search

redpanda-data / connect

Fancy stream processing made operationally mundane
https://docs.redpanda.com/redpanda-connect/about/
8.14k stars 840 forks source link

ollama: fix subprocess shutdown #2861

Closed rockwotj closed 2 months ago

rockwotj commented 2 months ago

Currently when starting a subprocess there is a hang on shutdown. You can't call Wait() after Kill() I guess. So instead use gracefully shutdown with SIGINT. However, if the process hangs at all, we'll forcibly kill it after 3 seconds.

rockwotj commented 2 months ago

Oops, thanks! Fixed the commit message 😅