Closed szymonorz closed 5 days ago
Hey @szymonorz 👋 Thank you for raising this issue! Could you please check if it is a duplicate of #2506? I think there's a PR opened for it here #2507, but I'm not very familiar with protobuf and it would be good to get an extra pair of eyes on that code.
Thanks for your reply. Yes, this is a duplicate. I didn't notice that issue and PR beforehand, sorry.
I tested out the PR on my use-case and it does solve the problem and from the looks of it I don't see anything wrong with the code. I'm gonna close this issue due to it being a duplicate
As of now
protobuf
processor doesn't have an ability to emit default values from protobuf messages.Meaning, given schema:
if
approved
was set tofalse
(bool
default value) then after converting the event to JSON, that field would be omitted from message.google.golang.com/protobuf
supportsEmitDefaultValues
in protojson.MarshallOptionsI think it would be a nice feature to have ability to enable it in Connect. I propose adding
emit_default_values
field to the processor. It should be disabled by default to not affect already existing pipelinesI'm willing to implement this if you are ok with having this feature