search

redpanda-data / connect

Fancy stream processing made operationally mundane
https://docs.redpanda.com/redpanda-connect/about/
8.14k stars 840 forks source link

feat: added timeplus output #2900

Closed ye11ow closed 1 month ago

ye11ow commented 1 month ago

This is the output component for Timeplus via ingest api. It supports both Cloud and self-hosted version of Timeplus Enterprise.

The input component is still WIP, I'll submit a separate PR for it.

ye11ow commented 1 month ago

The CI failed due to

Stale go.{mod,sum} detected. This can be fixed with 'make deps'.

I tried to run make deps but nothing changes, any suggestion? Thanks!

Jeffail commented 1 month ago

Hey @ye11ow don't worry about the go.mod complaints, there's a couple of linting errors worth looking at though:

  Warning: exported: exported const TargetTimeplus should have comment (or a comment on this block) or be unexported (revive)
  Warning: exported: exported type Client should have comment or be unexported (revive)
  Warning: exported: exported function NewClient should have comment or be unexported (revive)
  Warning: exported: exported type Writer should have comment or be unexported (revive)
ye11ow commented 1 month ago

Hey @ye11ow don't worry about the go.mod complaints, there's a couple of linting errors worth looking at though:

  Warning: exported: exported const TargetTimeplus should have comment (or a comment on this block) or be unexported (revive)
  Warning: exported: exported type Client should have comment or be unexported (revive)
  Warning: exported: exported function NewClient should have comment or be unexported (revive)
  Warning: exported: exported type Writer should have comment or be unexported (revive)

Thanks @Jeffail! Just fixed the lint 😄

ye11ow commented 1 month ago

Thanks @ye11ow for working on this! It looks good overall, but there are some small issues which I think should be addressed before merging.

Thank you @mihaitodor for such detailed comments! 😄 I'll address them.

ye11ow commented 1 month ago

@mihaitodor Fixed all the issues. Could you please check again? Thanks again for all the comments!

ye11ow commented 1 month ago

LGTM, thank you! Just needs a go mod tidy to pass the CI.

Thank you @mihaitodor for taking care of that for me! I'll pay more attention on this next time 😄