search

redpanda-data / console

Redpanda Console is a developer-friendly UI for managing your Kafka/Redpanda workloads. Console gives you a simple, interactive approach for gaining visibility into your topics, masking data, managing consumer groups, and exploring real-time data with time-travel debugging.
https://redpanda.com
3.8k stars 347 forks source link

Editing a Connector config with converter specific configs removes these #938

Open philipp94831 opened 11 months ago

philipp94831 commented 11 months ago

When editing a Kafka Connector config with converter specific configs, such as

"value.converter.schema.registry.url": "http://schema-registry:8081",

the config is removed fter updating it. The value converter used in this case is io.confluent.connect.avro.AvroConverter and configured as the default value converter for the Connect cluster. The converter specific config should not be removed in this case.

cobolbaby commented 11 months ago

Some custom configurations will be overwritten and updated, such as database.history.producer.sasl.mechanism in debezium-connector.

2023-12-01 14-58-19屏幕截图

rikimaru0345 commented 9 months ago

This seems to depend on the backend/exact connector that is being used. I tried gcs, http source, and S3 connectors, and they don't remove/change any properties. @weeco Can you look into this and make sure it isn't an issue with the backend, or even the connector?

@philipp94831 What is the exact name of the connector you used? Are you sending the update in JSON view, or do you switch back to the form view before updating? Also, can you check the network tab in the chrome dev tools? There should be http PUT to the connector being sent that contains the new config.

Image

philipp94831 commented 9 months ago

Hi, I am using ElasticsearchSinkConnector. "value.converter.schema.registry.url": "http://schema-registry:8081" is part of the GET connectors request but not part of the PUT when updating the connector through form view. JSON view works