redpanda-data / deployment-automation

Cluster configuration best practices
https://redpanda.com
Apache License 2.0
64 stars 46 forks source link

getting module into action #185

Closed gene-redpanda closed 1 year ago

gene-redpanda commented 1 year ago

Moving us from local TF files to an AWS terraform module for managing the cluster.

twmb commented 1 year ago

This is a big change -- any end user change?

gene-redpanda commented 1 year ago

@twmb so yes and no. the big end user change will be that there is a module and they might need to update their variables some. It may also require some state imports for people using the current setup which is potentially destructive if done really wrong but otherwise a fairly simple process of

terraform mv blah module.redpanda-cluster.blah

where blah is the prior resource's name. Here's an example from some blog: https://ryaneschinger.com/blog/terraform-state-move/

I intend to mark this as 3.0 to indicate that it does have potentially destructive consequences.

The advantage is that in future users can manage their upgrade with module version numbers and can easily roll back/forward/pin without any fiddling around.

twmb commented 1 year ago

^^Please create a "How to migrate from v2 to v3" checklist though, as follow up

gene-redpanda commented 1 year ago

Fair shout, migration guide is sensible

gene-redpanda commented 1 year ago

^^Please create a "How to migrate from v2 to v3" checklist though, as follow up

This is done