redpanda-data / helm-charts

Redpanda Helm Chart
http://redpanda.com
Apache License 2.0
78 stars 96 forks source link

redpanda: convert NOTES.txt to go #1403

Closed jan-g closed 4 months ago

jan-g commented 4 months ago

I didn't add the Ci machinery to compare a whole raft of (pretty much identical) NOTES.txt output, just ran it locally.

The _example-commands.tpl script calls into the gotohelm functions now.

RafalKorepta commented 4 months ago

https://github.com/redpanda-data/helm-charts/actions/runs/9760792194/job/26940439905?pr=1403#step:5:359

I believe it's the difference of running nix develop -c 'task ci:lint' or nix develop -c 'gofumpt -w .'

task: [ci:lint] gofumpt -w .
task: [ci:lint] git diff --exit-code
diff --git a/charts/redpanda/notes.go b/charts/redpanda/notes.go
index 05d11b2..8099fe9 100644
--- a/charts/redpanda/notes.go
+++ b/charts/redpanda/notes.go
@@ -149,7 +149,6 @@ func Notes(dot *helmette.Dot) []string {
            ``,
            fmt.Sprintf(`  %s`, RpkACLCreate(dot)),
        )
-
    }
    notes = append(notes,
        ``,
task: Failed to run task "ci:lint": exit status 1
chrisseto commented 4 months ago

I believe it's the difference of running nix develop -c 'task ci:lint' or nix develop -c 'gofumpt -w .'

Huh... Those should be the same 🤔

RafalKorepta commented 4 months ago

I found small problem

2024-07-02T14:09:16.2034506Z >>> helm install redpanda-pfzd2eoqxt charts/redpanda --namespace redpanda-pfzd2eoqxt --wait --values charts/redpanda/ci/96-audit-logging-values.yaml --timeout 600s --set=image.tag=
2024-07-02T14:09:16.3989941Z Error: INSTALLATION FAILED: YAML parse error on redpanda/templates/tests/test-kafka-sasl-status.yaml: error converting YAML to JSON: yaml: line 45: could not find expected ':'

https://github.com/redpanda-data/helm-charts/actions/runs/9762101576/job/26944710395?pr=1403#step:16:6299

RafalKorepta commented 4 months ago

It could be reproduced by

helm template charts/redpanda --namespace redpanda-pfzd2eoqxt --values charts/redpanda/ci/96-audit-logging-values.yaml.tpl
Error: YAML parse error on redpanda/templates/tests/test-kafka-sasl-status.yaml: error converting YAML to JSON: yaml: line 45: could not find expected ':'
jan-g commented 4 months ago

I'm not sure about the import thing either. It seems to come and go as I run the code generation; I can't fathom why.