search

redpanda-data / helm-charts

Redpanda Helm Chart
http://redpanda.com
Apache License 2.0
77 stars 96 forks source link

Assert all volumes are used #1467

Closed RafalKorepta closed 3 months ago

RafalKorepta commented 3 months ago

Remove from the StatefulSet -fs-validator if it is not used.

RafalKorepta commented 3 months ago

I should stand corrected. My mental model always think that changing anything other than few fields would end up in the following error. Apparently that's not the case as volumes is part of template which could be changed. 

Forbidden: updates to statefulset spec for fields other than 'replicas', 'ordinals', 'template', 'updateStrategy', 'persistentVolumeClaimRetentionPolicy' and 'minReadySeconds' are forbidden

My intuition and my memory is tainted by the fact I was fighting over changes in volumeClaimTemplates in https://github.com/redpanda-data/redpanda-operator/blob/923dc4c618b664b2c2ba1fc1f5d9877d18b5d343/src/go/k8s/pkg/resources/statefulset_update.go#L544-L548 https://github.com/redpanda-data/redpanda/pull/2728