Closed lemonprogis closed 3 months ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.
Could you run the following command?
nix develop -c task ci:lint
@chrisseto I'm unsure why those tests are failing, any help would be appreciated thanks!
The chart testing failures are due to docker's rate limits. We generally re-run those until they succeed (or get a new runner with a new IP really)
The go tests are due to changes in the chart's output. appProtocol
is now included as null
in the output due to a quick in gotohelm, which is technically acceptable.
To update the golden files run nix develop -c go test ./charts/redpanda -short -update
and commit the changes. Rafal or I can push the changes in if you'd prefer.
Ok cool, thanks for the offer, but I just pushed the change!
Due to unexpected quick release of Redpanda v24.2.2 I merged changes to template-cases.golden.txtar
. Could you rebase and re-run nix develop -c go test ./charts/redpanda -short -update
and push changes?
I couldn't push changes to your fork. Thank you for the contribution. It will be released soon.
Hello 👋
When exposing the admin API using Istio as this port isn't made available since it's not an http default name.
When I edit the service and add appProtocol: http the port becomes available with in istio. now it's available.
Since the listeners section is configurable, I added an additional optional key under
listeners.admin
, but gives the ability to allow instrumentation to pickup that it's not just raw tcp per K8s Service documentationIstio Docs around automatic detection