redpanda-data / helm-charts

Redpanda Helm Chart
http://redpanda.com
Apache License 2.0
77 stars 96 forks source link

fix(chart): support prerelease with kubeVersion for AWS EKS clusters #1480

Closed jgrasl closed 3 months ago

jgrasl commented 3 months ago

AWS EKS clusters has a -eks in their version numbers for example v1.28.11-eks-db838b0 which helm interprets as a prerelease version becasue of the dash after the semver version. It explained in detail here: https://github.com/helm/helm/issues/10375 Adding -0 to the kubeVersion 1.21.0 makes it possible to deploy the helm chart on EKS clusters.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

RafalKorepta commented 3 months ago

@jgrasl Could you run nix develop -c go test ./charts/console -short -update to update our golden test files?

jgrasl commented 3 months ago

@jgrasl Could you run nix develop -c go test ./charts/console -short -update to update our golden test files?

Done. Updated the testdata

RafalKorepta commented 3 months ago

I'm sorry. There is one additional update

nix develop -c task ci:lint

As per error in the CI https://github.com/redpanda-data/helm-charts/actions/runs/10305205098/job/28526760104?pr=1480#step:5:293

diff --git a/charts/console/README.md b/charts/console/README.md
index 87b89a8..b39c6dd 100644
--- a/charts/console/README.md
+++ b/charts/console/README.md
@@ -3,7 +3,7 @@
 description: Find the default values and descriptions of settings in the Redpanda Console Helm chart.
 ---

-![Version: 0.7.27](https://img.shields.io/badge/Version-0.7.27-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.7.0](https://img.shields.io/badge/AppVersion-v2.7.0-informational?style=flat-square)
+![Version: 0.7.28](https://img.shields.io/badge/Version-0.7.28-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.7.0](https://img.shields.io/badge/AppVersion-v2.7.0-informational?style=flat-square)

 This page describes the official Redpanda Console Helm Chart. In particular, this page describes the contents of the chart’s [`values.yaml` file](https://github.com/redpanda-data/helm-charts/blob/main/charts/console/values.yaml).
 Each of the settings is listed and described on this page, along with any default values.
@@ -21,7 +21,7 @@ Autogenerated from chart metadata using [helm-docs v1.13.1](https://github.com/n

 ## Requirements

-Kubernetes: `>= 1.21`
+Kubernetes: `>= 1.21.0-0`

 ## Settings
jgrasl commented 3 months ago

I'm sorry. There is one additional update

nix develop -c task ci:lint

As per error in the CI https://github.com/redpanda-data/helm-charts/actions/runs/10305205098/job/28526760104?pr=1480#step:5:293

diff --git a/charts/console/README.md b/charts/console/README.md
index 87b89a8..b39c6dd 100644
--- a/charts/console/README.md
+++ b/charts/console/README.md
@@ -3,7 +3,7 @@
 description: Find the default values and descriptions of settings in the Redpanda Console Helm chart.
 ---

-![Version: 0.7.27](https://img.shields.io/badge/Version-0.7.27-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.7.0](https://img.shields.io/badge/AppVersion-v2.7.0-informational?style=flat-square)
+![Version: 0.7.28](https://img.shields.io/badge/Version-0.7.28-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2.7.0](https://img.shields.io/badge/AppVersion-v2.7.0-informational?style=flat-square)

 This page describes the official Redpanda Console Helm Chart. In particular, this page describes the contents of the chart’s [`values.yaml` file](https://github.com/redpanda-data/helm-charts/blob/main/charts/console/values.yaml).
 Each of the settings is listed and described on this page, along with any default values.
@@ -21,7 +21,7 @@ Autogenerated from chart metadata using [helm-docs v1.13.1](https://github.com/n

 ## Requirements

-Kubernetes: `>= 1.21`
+Kubernetes: `>= 1.21.0-0`

 ## Settings

I ran it and updated the README.md