redpanda-data / helm-charts

Redpanda Helm Chart
http://redpanda.com
Apache License 2.0
77 stars 96 forks source link

Handle extraObjects like secrets #1580

Closed RogerBonati closed 2 weeks ago

RogerBonati commented 2 weeks ago

Provide extraObjects template to handle secrets

CLAassistant commented 2 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: RafalKorepta
:x: Roger Bonati


Roger Bonati seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant commented 2 weeks ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: RafalKorepta
:x: Roger Bonati


Roger Bonati seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

RafalKorepta commented 2 weeks ago

I would suggest to create new helm chart that would have one depedency on kminion. That way kminion helm chart state would not be cluttered with additional resources, that are not defined in this helm chart.

Reference: https://helm.sh/docs/helm/helm_dependency/#helm https://helm.sh/docs/chart_best_practices/dependencies/#helm

TheMeier commented 2 weeks ago

Having such a mechanism is quite common in the helm world nowadays. Especially since it avoids creating custom charts around subcharts. Maybe you could re-consider

chrisseto commented 2 weeks ago

If you have any references to other charts that do this, I'll take a look and re-evaluate the decision. However, given that there are myriad ways for end users to deploy a set of manifests without modifications to an upstream chart, I don't see a particularly compelling for us to maintain such a feature.

TheMeier commented 2 weeks ago

@chrisseto

Sure here is a few examples:

There is also an issue for helm to make this a helm-feature: https://github.com/helm/helm/issues/12653

TheMeier commented 1 day ago

@RafalKorepta @chrisseto any chance this is re-considered?