Closed RogerBonati closed 2 weeks ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: RafalKorepta
:x: Roger Bonati
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: RafalKorepta
:x: Roger Bonati
I would suggest to create new helm chart that would have one depedency on kminion. That way kminion helm chart state would not be cluttered with additional resources, that are not defined in this helm chart.
Reference: https://helm.sh/docs/helm/helm_dependency/#helm https://helm.sh/docs/chart_best_practices/dependencies/#helm
Having such a mechanism is quite common in the helm world nowadays. Especially since it avoids creating custom charts around subcharts. Maybe you could re-consider
If you have any references to other charts that do this, I'll take a look and re-evaluate the decision. However, given that there are myriad ways for end users to deploy a set of manifests without modifications to an upstream chart, I don't see a particularly compelling for us to maintain such a feature.
@chrisseto
Sure here is a few examples:
There is also an issue for helm to make this a helm-feature: https://github.com/helm/helm/issues/12653
@RafalKorepta @chrisseto any chance this is re-considered?
Provide extraObjects template to handle secrets