search

redpanda-data / helm-charts

Redpanda Helm Chart
http://redpanda.com
Apache License 2.0
77 stars 96 forks source link

console: consistently set `.Namespace` #1586

Open chrisseto opened 2 weeks ago

chrisseto commented 2 weeks ago

Prior to this commit objects produced from the console helm chart would inconsistently set namespace. This isn't particularly noticeable as kubectl and helm often set namespace transparently but it can cause issues when using other tooling.

This commit sets namespace on all objects it was set on, adds a test assertion that namespace is present across all objects, and removes usages of extraInitContainers from tests as they generated invalid manifests.

chrisseto commented 2 weeks ago

Hmmmm, there's an interesting CI failure. GoHelmEquivalence fails because the console chart isn't updated in tests which isn't possible because we need to merge the change to get a release of console....

RafalKorepta commented 2 weeks ago

Could we disable console in this test, release and then re-enable that test?