search

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
620 stars 122 forks source link

fix(e2e): fix https://github.com/cloudhut/kminion/issues/112 #121

Closed ggqshr closed 3 years ago

ggqshr commented 3 years ago

1.reduce init ticker time 2.fix topic exist check error

ggqshr commented 3 years ago

Hi, @weeco this is related to https://github.com/cloudhut/kminion/issues/114 and https://github.com/cloudhut/kminion/issues/112

weeco commented 3 years ago

Hey @ggqshr , just a heads up: I have not forgotten about you or this issue. I'll take a look asap.

weeco commented 3 years ago

I'll close this PR in favour of

(Topic exists check): https://github.com/cloudhut/kminion/commit/9162d2f6ec0128f65bdbe74c6f6be8cc40863ce3

and (Fix init ticker - follow up commits for the init procedure is about to come) https://github.com/cloudhut/kminion/pull/128/files

Thank you for raising the awareness about these two issues!

ggqshr commented 3 years ago

I'll close this PR in favour of

(Topic exists check): 9162d2f

and (Fix init ticker - follow up commits for the init procedure is about to come) https://github.com/cloudhut/kminion/pull/128/files

Thank you for raising the awareness about these two issues!

These are better ways to solve the problem. XD