introduce library-friendly kafka config

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.

MIT License

620 stars 122 forks source link

introduce library-friendly kafka config #146

Closed alenkacz closed 2 years ago

alenkacz commented 2 years ago

Providing filepaths is not convenient when one wants to use kminion as a library and already have the certs in memory.

CLAassistant commented 2 years ago

All committers have signed the CLA.

alenkacz commented 2 years ago

@weeco an alternative approach I like after sleeping on this would be to have both filepaths and bytes inside the same tls_config and using validation to prevent both being set... let me know what you like more

alenkacz commented 2 years ago

🤦‍♀️