search

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
610 stars 122 forks source link

add extraPorts for extraContainers #176

Closed cruwe closed 1 year ago

cruwe commented 1 year ago

In parallel to extraContainers, extraPorts may be required to scrape additional metrics generated by said extraContainers.

Thanks for your work on the kminion prometheus exporter, it has proven to be extremely useful.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

cruwe commented 1 year ago

politely bumping ... would this PR be acceptable for you? Thx again for your work on the kminion exporter

weeco commented 1 year ago

Hey @cruwe , sorry for the delay.

Generally I recommend to fork the chart at some point if the customization needs are too specific. We can't fit all usecases with a single chart in favour of maintainability and simplicity. I'll be okay with this change, just asked for additional documentation for this parameter in the values.yaml though.

Thanks

cruwe commented 1 year ago

Hi @weeco, I understand why you do not want excessive customization :-) ... just hoped as []extraContainers does exist, you wouldn't mind the []extraPorts.

Thank you for your time and for developing kminion. Cheers!