search

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
615 stars 123 forks source link

Make kminion helm chart compatible with K8s >= 1.25 #216

Closed panyuenlau closed 1 year ago

panyuenlau commented 1 year ago

autoscaling/v2beta1 is deprecated in 1.25, reference: https://kubernetes.io/docs/reference/using-api/deprecation-guide/#horizontalpodautoscaler-v125

This PR is to ensure that Kminion can be installed in k8s cluster with version >= 1.25 while not dropping support for <=1.23

I've tested the changes in actual K8s clusters with 1.25 and 1.21.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

panyuenlau commented 1 year ago

@alejandroEsc quick question - do we have a release plan for the chart itself?

Context: our project has an dependency on Kminion and the current Kminion version conflicts with the K8s version (1.25) that we would like to support in our next release (the helm chart is the only place that I found would need the modifications to support K8s 1.25), hence we would like to know the release plan and decide if we should fork the Kminion repo and have a downstream release ourself

alejandroEsc commented 1 year ago

@alejandroEsc quick question - do we have a release plan for the chart itself?

Context: our project has an dependency on Kminion and the current Kminion version conflicts with the K8s version (1.25) that we would like to support in our next release (the helm chart is the only place that I found would need the modifications to support K8s 1.25), hence we would like to know the release plan and decide if we should fork the Kminion repo and have a downstream release ourself

To be honest with you, that isnt something I know off the hand, ill ask internally and come back.

alejandroEsc commented 1 year ago

@alejandroEsc quick question - do we have a release plan for the chart itself?

Context: our project has an dependency on Kminion and the current Kminion version conflicts with the K8s version (1.25) that we would like to support in our next release (the helm chart is the only place that I found would need the modifications to support K8s 1.25), hence we would like to know the release plan and decide if we should fork the Kminion repo and have a downstream release ourself

Looks like we are releasing very soon! https://github.com/redpanda-data/kminion/pull/217

I believe we will be deprecating the chart from the current repo and will be moving it soon to the current redpanda one (not for this release) just a heads up.

panyuenlau commented 1 year ago

Thanks for the info, @alejandroEsc! I hope we are just moving the Kminion chart to https://github.com/redpanda-data/helm-charts/tree/main/charts without changing that much on the Kminion chart itself