search

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
601 stars 123 forks source link

Add support for SASL/OAUTHBEARER #223

Closed bachmanity1 closed 7 months ago

bachmanity1 commented 10 months ago

https://github.com/redpanda-data/kminion/blob/2f841e31aff86138def1b1e3716324ade8efe56c/kafka/config_sasl.go#L40-L41

We've been using kminion to monitor consumer group lags and so far our experience has been great, but soon we are planning to make all our Kafka clusters use SASL/OAUTHBEARER and it looks like we won't be able to use kminion anymore.

Can you please add support for SASL/OAUTHBEARER? Thanks!

bachmanity1 commented 7 months ago

@weeco if you don't mind I can start working on this feature sometime soon.

weeco commented 7 months ago

@bachmanity1 Please go ahead. You can have a look at the Console repository where OAuthBearer is already supported.

bachmanity1 commented 7 months ago

@weeco I've opened PR https://github.com/redpanda-data/kminion/pull/230

bachmanity1 commented 7 months ago

resolved by #230.