Add support for SASL/OAUTHBEARER

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.

MIT License

615 stars 123 forks source link

Add support for SASL/OAUTHBEARER #230

Closed bachmanity1 closed 10 months ago

bachmanity1 commented 10 months ago

I tested this on a SASL/OAUTHBEARER-enabled cluster, and it works well.

CLAassistant commented 10 months ago

All committers have signed the CLA.

bachmanity1 commented 10 months ago

@weeco Thanks for the review. I have addressed your comment.

weeco commented 10 months ago

@bachmanity1 One thing I missed in my review: Could we add OAUTHBEARER as a valid mechanism to the reference config on the mechanism field? Then it's good to merge I believe. Thank you again

bachmanity1 commented 10 months ago

@bachmanity1 One thing I missed in my review: Could we add OAUTHBEARER as a valid mechanism to the reference config on the mechanism field? Then it's good to merge I believe. Thank you again

Done.