search

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
601 stars 123 forks source link

Add kminion_kafka_topic_partitions and kminion_kafka_topic_retention_bytes metrics #235

Closed selsabil94 closed 5 months ago

selsabil94 commented 7 months ago

Fixes #234

This pull request addresses the issue by adding a new metrics to expose retention.bytes and partitions informations.

CLAassistant commented 7 months ago

CLA assistant check
All committers have signed the CLA.

weeco commented 5 months ago

Hey @selsabil94 , I appreciate the effort put into this, but I don't think that KMinion is the right tool to expose metrics (specifically the value of topic configurations) that are expected to be fairly static in normal cases.

KMinion promises to be feature-rich and highly configurable. Your desired request of exporting topic configurations as a feature would therefore tick the box "feature-rich", but not configurable. If you can change the implementation so that:

  1. This feature is opt-in via configuration
  2. The topic configurations that shall be exported are configurable

I'd be open to this. Ideally start with an issue describing the design and the configuration would be best, to ensure you are not spending time on something that we don't want to merge. Thank you!