redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
601 stars 123 forks source link

feat(helm): add tpl to config #239

Closed Wielewout closed 5 months ago

Wielewout commented 6 months ago

In case you would have an umbrella chart which would install both kafka and kminion, it would be impossible to inject e.g. the service name for the brokers (which is by default prefixed with the release name). With this PR for example the following values could be used in an umbrella chart:

kminion:
    config:
      kafka:
        brokers:
          - "{{ $.Release.Name }}-kafka.{{ $.Release.Namespace }}:9092"
Wielewout commented 5 months ago

Closing as this is not the appropriate place for helm charts anymore. Opened a PR on the helm chart repo: https://github.com/redpanda-data/helm-charts/pull/1015