search

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
615 stars 123 forks source link

Add support for hostAliases #259

Closed 0x5d closed 4 months ago

0x5d commented 4 months ago

Some external private connectivity alternatives, such as Private Service Connect (PSC) (GCP), PrivateLink (AWS) & Private Link (Azure) require incoming connections to use a different set of hostnames and ports, which are configured as an additional set of advertised listeners in the cluster.

These new advertised hostnames need not even exist in the VPC where Redpanda is deployed - it's expected that client connections will come from a different VPC, likely in a different e.g. project (GCP) or account (AWS). Therefore, the only way to measure SLA for them is to use the "path" clients would use (i.e. the load balancer or ports configured for PSC/ PrivateLink/ Private Link), and the only way to do that without creating additional DNS records in the Redpanda VPC (that would only be used for monitoring, anyway), is to add a set of hostAliases to the kminion instance in charge of monitoring it.

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

weeco commented 4 months ago

Change LGTM, the helm chart for KMinion is nowadays maintained in this repo though. The existing chart files are only hosted here for those that still depend on this chart, but it's effectively deprecated.

0x5d commented 4 months ago

Thanks for the heads-up. Moved it to https://github.com/redpanda-data/helm-charts/pull/1317.