Add consumer group coordinator label to consumer_group_info metric

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.

MIT License

620 stars 122 forks source link

Add consumer group coordinator label to consumer_group_info metric #81

Closed amuraru closed 3 years ago

amuraru commented 3 years ago

Fixes #79

@weeco I took inspiration from your other kowl project where you already integrated franz-go sharded responses. lmk, thanks

weeco commented 3 years ago

Hey @amuraru , thanks for another PR from you :-). Overall looks good to me, I just removed the wrapper around the sharded request to simplify the code a bit. In Kowl we did that to propagate potential issues (e.g. one or more group coordinators not responding) by showing what Brokers haven't responded. In kminion we can just print some warn/error log messages in that case and therefore we don't need that wrapper I think

amuraru commented 3 years ago

@weeco Martin, thanks for ammending the PR and integrating it. The changes look good to me!