search

redpanda-data / kminion

KMinion is a feature-rich Prometheus exporter for Apache Kafka written in Go. It is lightweight and highly configurable so that it will meet your requirements.
MIT License
620 stars 122 forks source link

Add namespace metadata to all k8s resource definitions #85

Closed amuraru closed 3 years ago

amuraru commented 3 years ago

This is needed in CICD tools where defaulting to namespace is not possible and a namespace is always required.

This is similar to v1 chart version: https://github.com/cloudworkz/kafka-minion-helm-chart/commit/c23f1065e1d02517fce1c0a9994fc4b94e6c84ba

weeco commented 3 years ago

I think you are supposed to specify the namespace via the helm command (--namespace flag) or if you use templating via kubectl (also --namespace flag). I omitted the namespace on purpose. See this issue: https://github.com/helm/helm/issues/5465

amuraru commented 3 years ago

I am aware of that issue but unfortunately beyond being a best practice it's not working in all CICD tools. We are using for example Spinnaker to drive deployment and neither passing the namespace via command line is not an option or defaulting to current ns is not an option. e.g https://spinnaker.io/guides/user/kubernetes-v2/deploy-helm/#configure-the-bake-manifest-stage Wondering though what are the side-effects and how having the Release.Namespace in impacting helm native installations

weeco commented 3 years ago

I can recall that we had the same discussion with kminion :D

amuraru commented 3 years ago

thanks Martin! :)