Closed jackietung-redpanda closed 1 month ago
Note: I did try to write a custom filter (e.g. get_deb_url
) in python code to avoid more craziness with defining even more URL constants. However I could not figure out a way to do it in our scenario (i.e. "embed the custom filter function within redpanda-ansible-collection
AND also calling it from within redpanda-ansible-collection
, but the invoking playbook living outside (in deployment-automation
).
I relented and just added some extra variables.
This looks pretty good to me. Have you done manual testing with it to validate outcomes?
Note: I did try to write a custom filter (e.g.
get_deb_url
) in python code to avoid more craziness with defining even more URL constants. However I could not figure out a way to do it in our scenario (i.e. "embed the custom filter function withinredpanda-ansible-collection
AND also calling it from withinredpanda-ansible-collection
, but the invoking playbook living outside (indeployment-automation
).I relented and just added some extra variables.
Yeah intent is to support the prior pattern re: deployment-automation which does mean things get a little tricky sometimes
Yes I tested manually by running the deb bundling and the airgap provisioning (for debs). Works fine. I will port the approach to rpm as well and publish the PR.
Manual testing setup:
@jackietung-redpanda add a bump to the Galaxy version then feel free to merge it. I will cut the release for you (haven't had time to automate it yet 😅)
@gene-redpanda I have made a stab at handling package split (as of 24.2), for debs so far.
If you are comfortable with this pattern, I will flesh out rpm as well. Then we are done (for now)