search

redpanda-data / redpanda-connect-helm-chart

Helm 3 repository for benthosdev/benthos
MIT License
36 stars 26 forks source link

Probe configs in values.yaml are ignored #78

Closed tbnguyen1407 closed 9 months ago

tbnguyen1407 commented 9 months ago

Version

2.1.0

Problem

Probe configs in values.yaml are ignored as templats are wrongly indented (14 spaces instead of 12 spaces).

Reproduction

Deploy with http.enabled

Output

W0123 03:05:01.788036 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].livenessProbe.httpGet.failureThreshold"
W0123 03:05:01.788068 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].livenessProbe.httpGet.periodSeconds"
W0123 03:05:01.788074 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].livenessProbe.httpGet.successThreshold"
W0123 03:05:01.788083 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].livenessProbe.httpGet.timeoutSeconds"
W0123 03:05:01.788090 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].readinessProbe.httpGet.failureThreshold"
W0123 03:05:01.788094 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].readinessProbe.httpGet.periodSeconds"
W0123 03:05:01.788099 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].readinessProbe.httpGet.successThreshold"
W0123 03:05:01.788103 2527026 warnings.go:70] unknown field "spec.template.spec.containers[0].readinessProbe.httpGet.timeoutSeconds"

Cause

https://github.com/benthosdev/benthos-helm-chart/blob/e7227e6fd4f2c195068dd12b1f231273df6db4f9/templates/deployment.yaml#L91-L99

Fix

Indentation should be updated to 12 spaces.

charlie-haley commented 9 months ago

I've updated the probes just to completely passthrough now, so if you're using https you will need to set the scheme now too. E.g

  readinessProbe:
    failureThreshold: 1
    periodSeconds: 5
    successThreshold: 1
    timeoutSeconds: 2
    httpGet:
      path: /ready
      port: http
      scheme: HTTPS
      httpHeaders:
      - name: My-Header
         value: Bar

I've created an issue to add schema linting so this can be better caught in the future https://github.com/benthosdev/benthos-helm-chart/issues/80

Fix for this has just been released as part of 2.1.1