search

redpanda-data / redpanda-connect-helm-chart

Helm 3 repository for benthosdev/benthos
MIT License
36 stars 26 forks source link

Allow using custom image repository #93

Closed cgoolsby closed 5 months ago

cgoolsby commented 5 months ago

In some on-prem environments users wish to pull from a local registry/repository as opposed to pulling from docker.io

This PR sets the default image.registry: docker.io and adds image.registry to the image: of the deployment.yaml template.

danriedl commented 5 months ago

You just have to prefix the image with the registry if you want to fallback to sth else: From this:

image: "jeffail/benthos"

To this:

image: "ghcr.io/jeffail/benthos"

This is the general approach of doing it. Consider it as how we do it in Dockerfiles:

FROM docker.redpanda.com/redpandadata/redpanda

Also you can then specify imagePullSecrets along with it.

charlie-haley commented 5 months ago

As @danriedl said, you can already do this by using repository: "ghcr.io/jeffail/benthos". Thanks anyway for taking the time to raise the PR!