search

redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.39k stars 577 forks source link

Operator does not take into account secret values when checking configuration changes #10926

Open nicolaferraro opened 1 year ago

nicolaferraro commented 1 year ago

Version & Environment

The operator always tries to reconcile some configuration properties if they are secret. One example is cloud_storage_secret_key, which is always reconciled because drifts are detected.

The reason seems to be that the admin API now does not reply with the value of the property, it replies with '[secret]', so whatever data is enforced by the operator, it is considered different from the actual value upon drift detection.

Redpanda version: (use rpk version): v23.1.10.

How to reproduce the issue?

  1. Fill the operator fields for cloud storage, including a secret key
  2. Wait ~10 minutes
  3. Cluster resource is marked as drifted (status->conditions) and configuration is reconciled again

JIRA Link: CORE-1311

joejulian commented 1 year ago

Blocked on #11286

githubexplorer38237213271 commented 6 months ago

@nicolaferraro As I mentioned on the blocked issue, maybe this can be solved by simply removing the secret check from the code that is checking for configuration drifts. Seems like an easy solution. Thoughts on that?