search

redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.51k stars 580 forks source link

Removal of `redpanda.remote.read|write` has incorrect semantics #11749

Open VladLazar opened 1 year ago

VladLazar commented 1 year ago

Version & Environment

Redpanda version: (use rpk version): v23.1.11

What went wrong?

A user sent an IncrementalAlterConfigs with the remove op code for redpanda.remote.write. Redpanda incorrectly interprets this as a request to disable remote writes.

What should have happened instead?

IncrementalAlterConfigs with remove op codes from redpanda.remote.write|read should set the properties back to their default value (from the cluster config).

How to reproduce the issue?

  1. set cloud_storage_remote_write_enabled to true
  2. rpk topic create test -c redpanda.remote.write=false
  3. rpk topic alter-config test --remove redpanda.remote.write
  4. remote write should now be enabled for test

JIRA Link: CORE-1354

piyushredpanda commented 1 year ago

Sounds like something we should block v23.2.1 for

VladLazar commented 1 year ago

Sounds like something we should block v23.2.1 for

I'm not sure. It's worked this way ever since redpanda.remote.write|read was introduced. I think it's quite rare to use remove with IncrementalRemoteConfigs. I'd expect users to set it explicitly most times. Not saying we shouldn't fix this; it's a bug, but trying to provide some colour here.

piyushredpanda commented 1 year ago

Got it, thanks!

github-actions[bot] commented 7 months ago

This issue hasn't seen activity in 3 months. If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.

github-actions[bot] commented 7 months ago

This issue was closed due to lack of activity. Feel free to reopen if it's still relevant.

piyushredpanda commented 7 months ago

We should keep this open and action.