search

redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.63k stars 585 forks source link

Tuner doesn't correctly make irqbalance ignore manually tuned irqs #17005

Open StephanDollberg opened 8 months ago

StephanDollberg commented 8 months ago

Version & Environment

Redpanda version: dev

What went wrong?

The tuner tries to make the irqbalance service ignore the irqs that it binds to certain cores.

It does that by passing --banirq=X to the irqbalance cli. To pass those additional arguments one has to change IRQBALANCE_ARGS in /etc/default/irqbalance. The specific arguments depend on the file and the distro most likely.

The logic is implemented here: https://github.com/redpanda-data/redpanda/blob/dev/src/go/rpk/pkg/tuners/irq/balance_service.go#L200

By default the tuner will set OPTIONS in /etc/default/irqbalance which however on ubuntu (used in cloud and many other places) seems to be incorrect these days.

What should have happened instead?

irqbalance service correctly doesn't reassign specified irqs.

Additional information

This is bad because it effectively makes modes like sq not work.

This affects:

Does not affect:

JIRA Link: CORE-1866

github-actions[bot] commented 1 month ago

This issue hasn't seen activity in 3 months. If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.