rpk: group describe supporting regex

daisukebe commented 3 months ago

Motivation explained in https://github.com/redpanda-data/redpanda/issues/17710

when redpanda admins/support want to get a description of all consumer groups...
the drill is a  "for i in " loop based on "rpk group list" ..
which runs
rpk group describe $i
on each group

We should have the ability to get the group description in a single rpk group command

I lean towards supporting regex in the describe command as topic describe does. As group describe already accepts more than one group in one command, I feel it is natural to support regex too.

Fixes https://github.com/redpanda-data/redpanda/issues/17710

Backports Required

[ ] none - not a bug fix
[ ] none - this is a backport
[ ] none - issue does not exist in previous branches
[ ] none - papercut/not impactful enough to backport
[x] v24.1.x
[x] v23.3.x
[ ] v23.2.x

Release Notes

Improvements

rpk: group describe supports --regex flag

daisukebe commented 3 months ago

Based on @r-vasquez 's feedback, made some changes below and rebased.

moved examples to the cobra.Command's Example field
made the regex function universal under the utils package, regex_filter.go
removed the regex logic from topic/utils.go
moved the test code from topic/utils_test.go to utils/regex_filter_test.go

daisukebe commented 3 months ago

/ci-repeat 3

daisukebe commented 3 months ago

@r-vasquez , is the build failure relevant?

r-vasquez commented 3 months ago

@daisukebe They were unrelated failures, not sure why the bot didn't retry (I did it manually). Merging it now, thanks

vbotbuildovich commented 3 months ago

/backport v24.1.x

vbotbuildovich commented 3 months ago

/backport v23.3.x

redpanda-data / redpanda