redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.65k stars 589 forks source link

[v23.3.x] gha: use oidc #23452

Closed andrewhsu closed 1 month ago

andrewhsu commented 1 month ago

Backport of PR #23423 Fixes #23437 jira: PESDLC-1736

This PR updates the workflow files triggered from the v23.3.x branch that use action aws-actions/configure-aws-credentials to run with OIDC tokens.

There were many conflicts when I first attempted to cherry-pick all the commits from PR #23423 that were unrelated to OIDC tokens and/or changed workflow files that wouldn't run on this v23.3.x branch, so I only cherry-picked a subset of the commits that are needed. This reduced the changeset to just these files:

  1. cloud-installpack-bk-trigger.yml
  2. promote.yml
  3. release-rp-storage-tool.yml

Backports Required

Release Notes

andrewhsu commented 1 month ago

@WillemKauf it seems that even if i backport commits from #23036 #23045 to this v23.3.x branch, there is still a rust error. is there something else i should also backport? or should i not backport those PR changes to this branch?

WillemKauf commented 1 month ago

Yeah looks like the transform SDK has issues with the bumped Rust version.

I'm not sure if the transform SDK can have its Rust version easily bumped and backported as well, or if you would prefer to just not backport either of those Rust related commits. For simplicity, I don't think it's a big deal to leave them out.

andrewhsu commented 1 month ago

For simplicity, I don't think it's a big deal to leave them out.

i dropped those commits. ready for review.