cst/cache: fix use-after-move caused by calling get_exception twice - Githubissues

redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!

https://redpanda.com

9.72k stars 591 forks source link

cst/cache: fix use-after-move caused by calling get_exception twice #24189

Closed nvartolomei closed 1 week ago

nvartolomei commented 1 week ago

cst/cache: fix use-after-move caused by calling get_exception twice

Found by @dotnwat https://github.com/redpanda-data/redpanda/pull/24000#discussion_r1849302646

Backports Required

[ ] none - not a bug fix
[ ] none - this is a backport
[ ] none - issue does not exist in previous branches
[ ] none - papercut/not impactful enough to backport
[x] v24.3.x
[x] v24.2.x
[x] v24.1.x

Release Notes

none

the below tests from https://buildkite.com/redpanda/redpanda/builds/58309#01934718-e08e-4cce-a4dd-3f1487db2549 have failed and will be retried
```
cloud_storage_smp_rpunit
```
the below tests from https://buildkite.com/redpanda/redpanda/builds/58309#01934718-e08c-499e-9345-99a76c7759eb have failed and will be retried
```
cloud_storage_smp_rpunit
```

vbotbuildovich commented 1 week ago

non flaky failures in https://buildkite.com/redpanda/redpanda/builds/58309#0193475a-7260-4de3-8c28-2946153f23f3:

"rptest.tests.node_metrics_test.NodeMetricsTest.test_node_storage_metrics"

vbotbuildovich commented 1 week ago

Retry command for Build#58309

please wait until all jobs are finished before running the slash command

/ci-repeat 1
tests/rptest/tests/node_metrics_test.py::NodeMetricsTest.test_node_storage_metrics

vbotbuildovich commented 1 week ago

/backport v24.3.x

vbotbuildovich commented 1 week ago

/backport v24.2.x

vbotbuildovich commented 1 week ago

/backport v24.1.x