redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.69k stars 591 forks source link

[CORE-8249] Allow more time for segment clean up #24245

Closed dotnwat closed 2 days ago

dotnwat commented 2 days ago

I see the last check in ducktape was here when ducktape was expecting this file to have been deleted on the broker:

  [INFO  - 2024-11-21 01:58:41,459 - topic_delete_test - topic_storage_purged - lineno:114]:   ip-172-31-45-99: 54-1-v1.log

Then a timeout occurs because the file isn't removed. But looking at the broker logs, the “removed:” line which happens right before ss::remove is called:

  DEBUG 2024-11-21 01:58:42,717 [shard 1:main] storage - segment.cc:171 - removed: "/var/lib/redpanda/data/kafka/topic-rmahmpbiye/2_29/54-1-v1.log" size 1048868

which was 1 second later. This appears to just be a race. Extend the time allowance before timeout.

Backports Required

Release Notes

piyushredpanda commented 2 days ago

I presume we need this in v24.3.x? How about other branches, @dotnwat ?

piyushredpanda commented 2 days ago

/backport v24.3.x

dotnwat commented 2 days ago

/backport v24.2.x