redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.53k stars 581 forks source link

Enable allocation failure injection in debug builds #3524

Closed jcsp closed 1 month ago

jcsp commented 2 years ago

We've talked from time to time about the need to do failure injection to make us more robust against bad_alloc exceptions -- depending on exactly where they come up, they often exercise rarely-taken error handling/destruction code paths -- this ticket is for suggesting a specific plan of action.

Seastar has a failure injection hook wrapped in include/seastar/util/alloc_failure_injector.hh but we don't use it.

JIRA Link: CORE-817

jcsp commented 2 years ago

@mmaslankaprv I know you had thoughts about bad_alloc failure injection -- is this anything like what you had in mind?

mmaslankaprv commented 2 years ago

This is exactly what i had in mind. I saw that the allocation failure injector was introduced in seastar recently

rockwotj commented 1 month ago

Closing this - we abort on allocation failures at the moment so it's not helpful to enable this.