Closed jcsp closed 1 month ago
@mmaslankaprv I know you had thoughts about bad_alloc failure injection -- is this anything like what you had in mind?
This is exactly what i had in mind. I saw that the allocation failure injector was introduced in seastar recently
Closing this - we abort on allocation failures at the moment so it's not helpful to enable this.
We've talked from time to time about the need to do failure injection to make us more robust against bad_alloc exceptions -- depending on exactly where they come up, they often exercise rarely-taken error handling/destruction code paths -- this ticket is for suggesting a specific plan of action.
Seastar has a failure injection hook wrapped in
include/seastar/util/alloc_failure_injector.hh
but we don't use it.SEASTAR_ENABLE_ALLOC_FAILURE_INJECTION
in our cmake files for debug mode onlyJIRA Link: CORE-817