search

redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.63k stars 585 forks source link

Redpanda doesn't support ListOffset v0 #4473

Open LenaAn opened 2 years ago

LenaAn commented 2 years ago

This came up in https://github.com/redpanda-data/redpanda/issues/4308

the time in ListOffsetRequest means different things in v0 and starting v1

In ListOffsetRequest/ListOffsetResponse v0, we return a list of offsets which is smaller than or equals to the target time.

Starting v1 (from KIP-79):

Look up the offsets for the given partitions by timestamp. The returned offset for each partition is the earliest offset whose timestamp is greater than or equals to the given timestamp in the corresponding partition. If no message has a timestamp that is greater than or equals to the target time, a null will be returned

Currently we always return earliest offset with timestamp >= timestamp is request, even tho we claim that we support v0, see schemata/list_offset_request.json

@piyushredpanda what do you think is the priority for this issue?

JIRA Link: CORE-897

emaxerrno commented 2 years ago

how old is v0 vs v1 - what kafka releases

dotnwat commented 2 years ago

this might be a case where v0 is supported but might as well be deprecated in practice. @LenaAn do you know which KIP changed the meaning?

LenaAn commented 2 years ago

KIP-79 changed the behavior, see link