search

redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.53k stars 582 forks source link

Use feature manager for read replica #5207

Closed LenaAn closed 2 years ago

LenaAn commented 2 years ago

Read replica changed the format of what is written to the controller log. Most likely we need to use feature manager for read replicas. Dod for this issue: either use it or have a good rational why it's ok not to use it.

Context about feather manager: https://vectorizedio.atlassian.net/wiki/spaces/CORE/pages/170491930/Features+Cluster+Logical+Versioning

LenaAn commented 2 years ago

From wiki page:

If your change to a data structure is backward compatible (e.g. appending a field to serde-encoded data structure), and old/new nodes can communicate using the modified structure, then there is no need for a new feature. You do not have to add a new feature each time you change a serde struct.

https://github.com/redpanda-data/redpanda/pull/5082/ appends fields to serde-encoded data, compat_version is not incremented, so it's not required to use feature table for this one. Closing this issue.