redpanda-data / redpanda

Redpanda is a streaming data platform for developers. Kafka API compatible. 10x faster. No ZooKeeper. No JVM!
https://redpanda.com
9.64k stars 586 forks source link

WARN: Failed to make upload candidate #9506

Open travisdowns opened 1 year ago

travisdowns commented 1 year ago

Version & Environment

Redpanda version: v23.1.1

What went wrong?

The following warning shows in the log:

WARN  2023-03-16 18:45:31,586 [shard  7] archival - [fiber47 kafka/topic1/216] - ntp_archiver_service.cc:1489 - Failed to make upload candidate

What should have happened instead?

No warnings without external causes that we can't avoid.

JIRA Link: CORE-1214

jcsp commented 1 year ago

Also noticed this today on the long running test cluster (it only got upgraded to 23.1 a day or so ago).

No sign of it having an impact (uploads appeared to be proceeding eventually), Evgeny suggested that it could happen in situations where the retention code is racing with the upload code, but it has been seen on topics that had infinite retention.

piyushredpanda commented 1 year ago

Sounds like something we should target for next minor, then?

jcsp commented 1 year ago

This has started to come up in automated tests.

FAIL test: KgoVerifierWithSiTestLargeSegments.test_si_with_timeboxed.cloud_storage_type=CloudStorageType.S3 (1/2 runs) failure at 2023-05-04T17:16:24.037Z: on (amd64, VM) in job https://buildkite.com/redpanda/vtools/builds/7377#0187e5cb-c7ac-45a5-a783-89ebbe7df193

FAIL test: CloudRetentionTest.test_cloud_retention.max_consume_rate_mb=20.cloud_storage_type=CloudStorageType.S3 (1/31 runs) failure at 2023-05-05T04:45:27.129Z: on (arm64, VM) in job https://buildkite.com/redpanda/vtools/builds/7385#0187e85f-7419-4984-9d70-bec9324a05ac

ztlpn commented 1 year ago

Created https://github.com/redpanda-data/redpanda/issues/10583 so that it easier for PR authors to find and refer to the issue.

mmaslankaprv commented 1 year ago

for me it looks like the issue we are seeing in the mentioned tests and the one mentioned in the issue title are two different problems. Then one that started happening in the mentioned tests is related with the size mismatch, whereas the problem seen in the PoC is more general as it hits the case where there is no upload candidate at all.

github-actions[bot] commented 2 months ago

This issue hasn't seen activity in 3 months. If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in two weeks.