redpen-cc / redpen

RedPen is an open source proofreading tool to check if your technical documents meet the writing standard. RedPen supports various markup text formats (Markdown, Textile, AsciiDoc, Re:VIEW, reStructuredText and LaTeX).
https://redpen.cc
Apache License 2.0
565 stars 74 forks source link

Hyphenation - incorrect corrections #826

Open dylan-chong opened 6 years ago

dylan-chong commented 6 years ago

For text:

It would be able to work.

This error occurs:

screen shot 2018-03-30 at 12 58 41 pm

However, I don't believe this is a correct suggestion.

dylan-chong commented 6 years ago

Another example: Information has been copied below # redpen suggests 'has-been' should be hyphenated, but i have never seen those two words hyphenated before

nicolaiskogheim commented 6 years ago
Thank you for your interest.

Hyphenation: This phrase should be hyphenated (ie: "Thank-you").

Thank-you, redpen. 😁

dylan-chong commented 6 years ago

@nicolaiskogheim No, not always https://ell.stackexchange.com/questions/58894/should-i-hyphenate-thank-you

This is the reason for incorrect hyphenation. Redpen assumes that these words are nouns which should be hyphenated, when they often are verbs, which should not be.

EDIT: @nicolaiskogheim I may have misinterpreted your post ...

nicolaiskogheim commented 6 years ago

EDIT: @nicolaiskogheim I may have misinterpreted your post ...

Indeed, hehe. I'm aware that "thank-you" is a noun, but I never mean to use it. In my texts there's always five or more suggestions to hyphenate words, but it's never right.

takahi-i commented 6 years ago

Sorry for the late response 🙇 It looks like we need to apply part of speech tagger to handle this problem 🤔

dylan-chong commented 6 years ago

After some consideration, I believe the best solution would be to disable hyphenation checking for now.

I think that uses of the words that should be hyphenated are quite rare, and uses of the words that should not be hyphenated are very common. Therefore there would be many warnings that one has to ignore, which can lead to accidentally ignoring real warnings. It is also confusing to be asked to use red pen to check grammar, then be asked to ignore some warnings.

Given your response above @takahi-i , it may be tricky and time consuming to solve this problem.