search

redphx / better-xcloud-android

Android app to improve Xbox Cloud Gaming (xCloud) and Remote Play experiences
https://better-xcloud.github.io/android
MIT License
158 stars 3 forks source link

[Bug] App settings icon overlaps the search shortcut #103

Closed piersandro closed 5 months ago

piersandro commented 5 months ago

Device

Phone/Tablet

Device name

Logitech G Cloud

Android Version

Android 11

App version

0.16.0

Script version

4.7.0

WebView name and version

Android System WebView 125.0.6422.165

Reproduction Steps

I noticed that the app settings icon overlaps with the search shortcut indication.

How to reproduce: 1) Open xCloud App 2) Navigate on the interface via the controller buttons 3) Scroll down and up 4) The Settings icon will overlaps with the search shortcut indication.

telegram-cloud-photo-size-4-5989848514869445358-x

The search shortcut is not viewable if you scroll with the touchscreen.

piersandro commented 5 months ago

I think in part is a duplicate of this enhancement request: https://github.com/redphx/better-xcloud-android/issues/93

KingNothing81 commented 5 months ago

I think in part is a duplicate of this enhancement request: #93

Hi ... That's my enhancement request. And on your shared screenshot I can see that you also don't have a refresh button on top of the settings button? So why do I have one?

@redphx: Does the refresh button only show up on Android TV? Because as I need a mouse to press that button, I could also just use "pull to refresh". Because that also works with a mouse if you press and hold the left mouse button at the top of the page and then pull down.

piersandro commented 5 months ago

Hi ... That's my enhancement request. And on your shared screenshot I can see that you also don't have a refresh button on top of the settings button? So why do I have one?

I use Logitech G Cloud. Essentially it's an Android tablet with an attached controller. The refresh button I think is missing because the device have a built-in touch screen.

redphx commented 5 months ago

This is not really an issue because the Settings button only blocks the shortcut when you're at the top of the page. When scrolling down the search shortcut is still there, so users can still see it.
Fixing it will break the UI and I don't like it.

piersandro commented 5 months ago

Ok, but moving the settings icon to the left could be a solution.

KingNothing81 commented 5 months ago

Ok, but moving the settings icon to the left could be a solution.

Hm, but if it's on the left side, it will be in "conflict" with the Xbox Guide menu. ;)

My suggestion was to do those things with an app dialog box that shows up on the screen if the user presses Android's Back button (as every Android (TV) device has one). And that would include all needed options like "open app settings", "refresh page", "quit app" and maybe "check for updates". So you can check for pending updates without having to close and reopen the app first.

piersandro commented 5 months ago

Hm, but if it's on the left side, it will be in "conflict" with the Xbox Guide menu. ;)

No, it depends on z-index level. It could be covered when the Guide is opened. But my point of view is as an handheld user.