[Feature] Option to disable k&m emulation of controller in games that support true k&m

redphx / better-xcloud

Userscript to improve Xbox Cloud Gaming (xCloud) and Remote Play experiences on web browsers

https://better-xcloud.github.io

MIT License

771 stars 47 forks source link

[Feature] Option to disable k&m emulation of controller in games that support true k&m #391

Closed Danfun64 closed 4 months ago

Danfun64 commented 4 months ago

Device

Phone/Tablet

Operating System

Windows

Browser

Chrome/Edge/Chromium

Suggestion

Microsoft has recently added true keyboard and mouse support for a select number of games as a "preview feature". As of this Xbox Insider Release Notes page, 14 games can run K&M natively. It would be nice if Better XCloud could detect if the game being played supports native k&m support and bypass the emulated controller feature.

redphx commented 4 months ago

This feature has been implemented in 4.0.1.
Which game did you test?

Danfun64 commented 4 months ago

I didn't realize you implemented this feature. I should probably test a game before I close this though.

Danfun64 commented 4 months ago

Okay, tested it out, noticed some issues.

The ESC key doesn't seem to work when "Emulate Controller with Mouse and Keyboard" is turned on. (I noticed this when I tested Quake II)
I'm not sure how I feel about the F8 key being hijacked by the enable/disable emulated mouse and keyboard functionality. It's probably no different from how F9 is hijacked for the Xbox menu, but I do find it worth noting.

I haven't tried to determine how real K&M affects local coop with one or more joysticks.

redphx commented 4 months ago

Fixed: https://github.com/redphx/better-xcloud/raw/typescript/dist/better-xcloud.user.js

You need to hold the ESC key
Nothing sketchy about the F8 button. Feel free to check the source code.