redphx / better-xcloud

Userscript to improve Xbox Cloud Gaming (xCloud) and Remote Play experiences on web browsers
https://better-xcloud.github.io
MIT License
819 stars 50 forks source link

[Feature] Keyboard and Mouse Support #98

Closed braxento closed 10 months ago

braxento commented 1 year ago

Keyboard and Mouse support, pretty explanatory.

Not sure if this helps but: https://github.com/guilhermejfreitas/xcloud-with-keyboard-mouse

redphx commented 10 months ago

Added "Map mouse to" feature

image
redphx commented 10 months ago

One question: does the mouse feel responsive?
My laptop is really laggy + I have a high ping when using xCloud in general so it's really difficult for me to know how good/bad this feature is at the moment.

delicio002 commented 10 months ago

Uma pergunta: o mouse responde? Meu laptop está muito lento + tenho um ping alto ao usar o xCloud em geral, então é muito difícil para mim saber o quão bom/ruim esse recurso é no momento.

Yes, the mouse is responding normally, I tested it here and it's already better than last time, I haven't been able to test the mouse mapping yet.

LucasG021 commented 10 months ago

I'm having trouble mapping the mouse; when I click on the input select, nothing appears

redphx commented 10 months ago

I'm having trouble mapping the mouse; when I click on the input select, nothing appears

Which browser? Did you click on the "Edit" button?
If possible please provide a video capture.

LucasG021 commented 10 months ago

I tested it in two browsers, Google Chrome and Edge. I tried resetting the browser settings, but it didn't solve the issue. Here's a video:

https://github.com/redphx/better-xcloud/assets/47404380/0b430dfe-a56b-44dc-a33a-a7c5836c2148

redphx commented 10 months ago

Try to create a new preset. The preset from the older version might be bugged.

If it still doesn't work, please take a screenshot of the error in Console tab of Chrome DevTools.
You may need to clear the data in Chrome Devtools > Application > IndexedDB > xbox.com > right-click on "BetterXcloud" > Delete all > Reload the website

LucasG021 commented 10 months ago

Now it works, thanks

redphx commented 10 months ago

@LucasG021 how was the experience?

delicio002 commented 10 months ago

I couldn't, because I don't know how to use devtools

redphx commented 10 months ago

I couldn't, because I don't know how to use devtools

Try again with the latest version

Tak-attack commented 10 months ago

The issue is different from MKB, but since the change to the new configuration UI, the pull downs and sliders do not move when clicked. I have reinstalled better xcloud and deleted the cookie from xbox.com but it still does not work.

・Windows 10 ・Edge / Chrome

redphx commented 10 months ago

The issue is different from MKB, but since the change to the new configuration UI, the pull downs and sliders do not move when clicked. I have reinstalled better xcloud and deleted the cookie from xbox.com but it still does not work.

・Windows 10 ・Edge / Chrome

@Tak-attack in the stream settings?
Do you see any error in the Console tab of Chrome DevTools?

redphx commented 10 months ago
image

Added feature to lock & hide the cursor. I tested and it felt much better than before.

All the features I wanted to added for the first version are done. If there are no more bugs I'll release the full version, so please help me test it.

Thanks.

LucasG021 commented 10 months ago

It's working perfectly for me. I tested it on the Edge and Chrome browsers. Thank you for your effort in providing such a useful extension. Soon, I'll be making a donation to express my gratitude for this.

Tak-attack commented 10 months ago

MKBとは問題が異なりますが、新しい設定UIに変更されてから、プルダウンやスライダーをクリックしても動かなくなりました。より良い xcloud を再インストールし、xbox.com から Cookie を削除しましたが、まだ機能しません。 ・Windows 10 ・エッジ / クローム

@Tak-attackストリーム設定で?Chrome DevTools の [コンソール] タブにエラーが表示されますか?

Yes, it is the Stream Settings pull-down. But I just updated the script and checked again, and the Stream Settings pull-down menu and slider work as expected. Thanks for the fix!

jonatanjrb commented 10 months ago

It doesn't work for me at all, I've tried uninstalling and reinstalling it about 3 times, I've tried disconnecting my controller, and it doesn't work, it's a shame I wanted to do a mission in GTA that I could only do with a mouse in time

redphx commented 10 months ago

@jonatanjrb Browser? OS? Device? Screenshot? Video?

Do you see any error in the Console tab of Chrome DevTools?

redphx commented 10 months ago

@jonatanjrb do you have the "Controller shortcuts" setting enable? Currently it conflict with the MKB feature, and I'll temporary disable it in the next version.

redphx commented 10 months ago

Version 3.0 with MKB support has been released. Thanks everyone for the help!

delicio002 commented 10 months ago

Hello, could you explain to me what these functions (STICK DECAY STRENGTH) and (STICK DECAY MINIMUM) are for?

redphx commented 10 months ago

Hello, could you explain to me what these functions (STICK DECAY STRENGTH) and (STICK DECAY MINIMUM) are for?

If you click on the (i) icon next to the big Mouse & Keyboard text it will take you to the docs: https://better-xcloud.github.io/mouse-and-keyboard/

Sus002 commented 10 months ago

hello! first of all i wanted to thank you for doing this, its incredible, but now that the official release is out, i coudnt help to notice that the mouse being recognized internally by the mfs game and halo its not available anymore, for instance before on the beta i could move the mouse intwernally on the game, but now its just mapping the joystick, just wanted to ask if its a bug or you took it out, but even tho thanks for the great job on this exstention, fr.

redphx commented 10 months ago

@Sus002 the native mkb support feature can be disabled by xCloud anytime so I don't want to enable it by default.

If you want to try it, change the ENABLE_NATIVE_MKB_BETA flag to true, and add the game you want to try to the window.NATIVE_MKB_TITLES list.

Sus002 commented 10 months ago

@Sus002 the native mkb support feature can be disabled by xCloud anytime so I don't want to enable it by default.

If you want to try it, change the ENABLE_NATIVE_MKB_BETA flag to true, and add the game you want to try to the window.NATIVE_MKB_TITLES list.

Ok thanks man!

jonatanjrb commented 10 months ago

no longer needed, thanks for your attention with stable update 3.0 with keyboard and mouse support it finally worked, I don't know what made it different for the final version that it didn't have in this test version but it worked, and it worked with the controller at the same time, it was very It's cool, I can use the mouse and the controller at the same time, the only thing is that you can't increase the speed of the pointer on the computer in GTA, for example, it turned everything up to maximum and it was still too slow, if you can do something to increase the speed? sensitivity to 300% or more would be great, for games like GTA that have a computer inside the game with a mouse pointer


De: redphx @.> Enviado: quinta-feira, 4 de janeiro de 2024 23:18 Para: redphx/better-xcloud @.> Cc: jonatanjrb @.>; Mention @.> Assunto: Re: [redphx/better-xcloud] [Feature] Keyboard and Mouse Support (Issue #98)

@Sus002https://github.com/Sus002 the native mkb support feature can be disabled by xCloud anytime so I don't want to enable it by default.

If you want to try it, change the ENABLE_NATIVE_MKB_BETA flag to true, and add the game you want to try to the window.NATIVE_MKB_TITLES list.

— Reply to this email directly, view it on GitHubhttps://github.com/redphx/better-xcloud/issues/98#issuecomment-1878031586, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ALMTPZI6T3HNNCFVAWUEA73YM5PHZAVCNFSM6AAAAAA3OZHTTSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZYGAZTCNJYGY. You are receiving this because you were mentioned.Message ID: @.***>

jonatanjrb commented 10 months ago

I'm from Brazil and I'm using a translator controller and what do we call the joystick ok, so in my message when I say controller or control I'm referring to the xbox joystick in my case

redphx commented 10 months ago

@jonatanjrb for now you can edit the code to change the sensitivities: Line 3759 and Line 3772

delicio002 commented 10 months ago

Hi, could you tell me how I can modify the code on my computer, so that I can try the native feature?