redphx / joydance

Use Joy-Cons to play Ubisoft's Just Dance on all platforms
MIT License
84 stars 5 forks source link

Suggestions for ease of use #18

Open Evaldash opened 2 years ago

Evaldash commented 2 years ago

Hi, I've looked at this project and have two suggestions:

  1. You could bundle the app into a single package and generate releases, if there's any hope of non-techies to use it. :) I've experimented with pyInstaller (https://github.com/pyinstaller/pyinstaller), and I was able to bundle your project into a single exe file, so no more messing with python for the regular users.
  2. I believe the app could open a webview automatically, once the server is started (some people want to host from their computers, not raspberry pi's or servers). I've experimented with webview, and came up with this (dance_client.py):
    
    import os
    import subprocess
    import webview

webview.create_window('Just dance!', 'http://localhost:32623', confirm_close=True) dance_server = subprocess.Popen(["python", "dance.py"]) webview.start()

terminate server on window close

dance_server.terminate()



![image](https://user-images.githubusercontent.com/61429051/171747789-cb456b48-41cb-4d99-8397-6cec18cf6e13.png)

It can still be improved, but that's my idea.

Is this project open to pull requests? I'd share my code :)
redphx commented 2 years ago

Please create a MR so I can take a look. Thank you.

TeaLove0 commented 1 year ago

I don't know how much it is possible, but I would like to add the ability to log into your Ubisoft account in JoyDance for the 2016-2018 version, as it was on a smartphone. And it's not very convenient to play as a guest, I would like to be able to change my dance card.

BroJac5246 commented 1 year ago

I don't know how much it is possible, but I would like to add the ability to log into your Ubisoft account in JoyDance for the 2016-2018 version, as it was on a smartphone. And it's not very convenient to play as a guest, I would like to be able to change my dance card.

It was determined in #4 that this won't be added :(