redphx / joydance

Use Joy-Cons to play Ubisoft's Just Dance on all platforms
MIT License
84 stars 5 forks source link

add pro controller support #43

Open JJRoyale opened 1 year ago

JJRoyale commented 1 year ago

as bad as it sounds, my joy cons are broken and i play jd with the nx pro controller, can you add this to joydance?

JJRoyale commented 1 year ago

@redphx

BroJac5246 commented 1 year ago

This sounds like a really good way to break your Pro Controller. Even if this were to be added (which I doubt), I would advise against this.

Also, how did you break both of your Joy Cons?

JJRoyale commented 1 year ago

i dont care, im pretty careful + if you think like that then your phone could break too by playing

Il giorno dom 11 giu 2023 alle ore 16:45 BroJac5246 < @.***> ha scritto:

This sounds like a really good way to break your Pro Controller. Even if this were to be added (which I doubt), I would advise against this.

— Reply to this email directly, view it on GitHub https://github.com/redphx/joydance/issues/43#issuecomment-1586193020, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXQYZ5XMADTGHWZQVJGJ3WTXKXKXRANCNFSM6AAAAAAZCHNGYQ . You are receiving this because you authored the thread.Message ID: @.***>

JJRoyale commented 1 year ago

Also, how did you break both of your Joy Cons?

I dunno, all of my joy cons either don't charge, have stick drift, they just don't work for gaming.

BroJac5246 commented 11 months ago

Why did you reopen this?

superpawko commented 11 months ago

I would also like to see pro controller support. Why? Because Just Dance Watch from aliexpress pretend to be a Pro controller. I was able to use it with Yuzu and BetterJoy.

BroJac5246 commented 11 months ago

I would also like to see pro controller support. Why? Because Just Dance Watch from aliexpress pretend to be a Pro controller. I was able to use it with Yuzu and BetterJoy.

Sure, but it's also an unofficial product— it's not representative of the actual experience with a Pro Controller. And there's no reason to add support just for some random Chinese product.

superpawko commented 11 months ago

Yes i know. Sorry. I am in a dreamland. But I dont have a possibility to update joycons. And I find it expensive to buy whole console just to play 5 hours a week.

I wish your software can use any motion controller, like BetteryJoy creates motion server for cemu.

Could you just add functionality to use keyboard and use motion controllers on 127.0.0.1:26760?

Probably not. Thanks anyway!

BroJac5246 commented 11 months ago

Yes i know. Sorry. I am in a dreamland. But I dont have a possibility to update joycons. And I find it expensive to buy whole console just to play 5 hours a week.

Do you have any friends who would let you update your Joy-Cons using their Switch?

I wish your software can use any motion controller, like BetteryJoy creates motion server for cemu.

Could you just add functionality to use keyboard and use motion controllers on 127.0.0.1:26760?

Probably not. Thanks anyway!

I would create separate issues for those, after checking for duplicates. They're more likely to be seen that way. However, redphx has made it pretty clear that JoyDance is only for Joy-Cons and anyone who wants to extend that functionality can fork the project. There's not much either of us can do about that short of forking the repo, since this project is barely maintained anyways.

justasierof commented 5 months ago

Just easy, in pycon folder, edit constants.py and change the joycon vendor id, joycon l product id, joycon r product id with the pro controller vendor and product id

BroJac5246 commented 5 months ago

Just easy, in pycon folder, edit constants.py and change the joycon vendor id, joycon l product id, joycon r product id with the pro controller vendor and product id

Did that work for you?

justasierof commented 5 months ago

Yes, but I only tried with jd2017pc , i don't know if the buttons will work

BroJac5246 commented 5 months ago

Yes, but I only tried with jd2017pc , i don't know if the buttons will work

The right ones might, though the left ones probably won't. Still, that's interesting.