redplanetlabs / proxy-plus

A replacement for Clojure's proxy that's 10x faster and more usable
Apache License 2.0
175 stars 10 forks source link

Upgrade to latest (newer) asm library - support newer jdk's #16

Closed ieugen closed 1 year ago

ieugen commented 2 years ago

Hello,

ASM has eveloved, the current release is from 2013. New versions support newer JDK releases. See https://asm.ow2.io/versions.html .

I did upgrade locally and it builds and the tests pass - but did not try any code against other jvm's .

Perhaps an automated build to test against multiple JVM might be a good option.

(⎈ |libris-k2-admin:prod)ieugen@daos-495:~/.../clojure/proxy-plus$ lein test
Retrieving org/ow2/asm/asm/9.2/asm-9.2.pom from central
Retrieving org/ow2/asm/asm-commons/9.2/asm-commons-9.2.pom from central
Retrieving org/ow2/asm/asm-tree/9.2/asm-tree-9.2.pom from central
Retrieving org/ow2/asm/asm-analysis/9.2/asm-analysis-9.2.pom from central
Retrieving org/ow2/asm/asm-util/9.2/asm-util-9.2.pom from central
Retrieving org/ow2/asm/asm-commons/9.2/asm-commons-9.2.jar from central
Retrieving org/ow2/asm/asm-tree/9.2/asm-tree-9.2.jar from central
Retrieving org/ow2/asm/asm-util/9.2/asm-util-9.2.jar from central
Retrieving org/ow2/asm/asm/9.2/asm-9.2.jar from central
Retrieving org/ow2/asm/asm-analysis/9.2/asm-analysis-9.2.jar from central

lein test com.rpl.proxy-plus-test

Ran 13 tests containing 52 assertions.
0 failures, 0 errors.
alexanderkiel commented 2 years ago

Even if the new byte code features are not useful for proxy+, the lib should be really updated, because it's a runtime dependency.

alexanderkiel commented 2 years ago

Works for me with ASM 9.2.

nathanmarz commented 1 year ago

Closing because ASM is shaded now