search

redplanetlabs / specter

Clojure(Script)'s missing piece
Apache License 2.0
2.51k stars 102 forks source link

Add arglist metadata to navs. #290

Closed phronmophobic closed 3 years ago

phronmophobic commented 4 years ago

It's driving me nuts that none of the navigators have the :arglists metadata.

No :arglists metadata means the args for navigators don't pop up in my editor. The arglists also don't show up for my editor's find doc feature or in the repl with clojure.repl/doc.

nathanmarz commented 4 years ago

I'll need you to sign a contributor agreement before I can merge this in. Can you send your email to nathan@nathanmarz.com and I'll send it over to you via Adobe Sign?

phronmophobic commented 4 years ago

The code from src/clj/com/rpl/specter.cljc is code that is copied and modified from https://github.com/clojure/clojure/blob/master/src/clj/clojure/core.clj. Should I move that code into a separate commit or pull request? Do I need to rewrite it so it's not derivative from clojure core code?

The changes in src/clj/com/rpl/specter/macros.clj are my own.

phronmophobic commented 3 years ago

Is there anything I can do on my end to make progress on this?