reserved identifier violation

redpony / cdec

Decoder, aligner, and model optimizer for statistical machine translation and other structured prediction models based on (mostly) context-free formalisms

http://cdec-decoder.org/

Apache License 2.0

183 stars 77 forks source link

reserved identifier violation #56

Open elfring opened 10 years ago

elfring commented 10 years ago

I would like to point out that identifiers like "_ALIGNER_H_" and "_HG_H_" do not fit to the expected naming convention of the C++ language standard. Would you like to adjust your selection for unique names?

redpony commented 10 years ago

I didn't realize this restriction, i made a change to most of the code in the decoder. will finish up later.

elfring commented 10 years ago

How do you think about to make your include guards not only standard-compliant but also unique by appending a kind of UUID?