redpony / cdec

Decoder, aligner, and model optimizer for statistical machine translation and other structured prediction models based on (mostly) context-free formalisms
http://cdec-decoder.org/
Apache License 2.0
183 stars 77 forks source link

index not correct in fast_align.cc when computing emp_feat #62

Open hitochan777 opened 9 years ago

hitochan777 commented 9 years ago

When computing emp_feat in fast_align.cc(line 205), I think index j should be j+1 since j start from 0. emp_feat += DiagonalAlignment::Feature(j, i, trg.size(), src.size()) * p;

The other parts pass j+1 instead of j.